doc: consolidate -j information for make #12437
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our docs contain a mixture of `make -j4`, `make -j8`, and `make` without a `-j` option at all. Standardize on not specifying a `-j` option, but include information in `BUILDING.md` (where people are likely to be looking the first time they build Node.js) about setting `-j`, including the possibility of using `MAKEFLAGS`.
nodejs-github-bot
added
build
thefourtheye
approved these changes
Apr 16, 2017
|
@Trott I'm pretty sure we already had this discussion and standardized in #9961. Not sure why the Basically the consensus in that PR was that we should standardize on I think it's better to have EDIT: See also #8286 |
2 tasks
ghost
approved these changes
Apr 16, 2017
jasnell
approved these changes
Apr 17, 2017
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our docs contain a mixture of
make -j4,make -j8, andmakewithouta
-joption at all.Standardize on not specifying a
-joption, but include information inBUILDING.md(where people are likely to be looking the first time theybuild Node.js) about setting
-j, including the possibility of usingMAKEFLAGS.Checklist
Affected core subsystem(s)
build doc meta